Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox facet duplication multi-select facet bug #4203

Conversation

demiankatz
Copy link
Member

This PR was opened in response to a report that checkbox filters were sometimes getting duplicated in the URL. It adds a test to reproduce the problem (which fails in dev yet passes here) and solves the issue by applying parameter normalization more consistently.

@demiankatz demiankatz added this to the 10.1.2 milestone Jan 23, 2025
@demiankatz demiankatz requested a review from EreMaijala January 23, 2025 14:04
@demiankatz demiankatz merged commit b56b22b into vufind-org:release-10.1 Jan 24, 2025
6 checks passed
@demiankatz demiankatz deleted the release-10.1-fix-checkbox-facet-duplication branch January 24, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants